https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94629

--- Comment #21 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Frederik Harwath <frede...@gcc.gnu.org>:

https://gcc.gnu.org/g:15256c8a8ac6573d250506c40dbe13082186c2aa

commit r10-7845-g15256c8a8ac6573d250506c40dbe13082186c2aa
Author: Frederik Harwath <frede...@codesourcery.com>
Date:   Tue Apr 21 12:36:14 2020 +0200

    Remove fishy self-assignment in omp-low.c [PR94629]

    The PR noticed that omp-low.c contains a self-assignment in the
    function new_omp_context:

    if (outer_ctx) {
        ...
        ctx->outer_reduction_clauses = ctx->outer_reduction_clauses;

    This is obviously useless.  The original intention might have been
    to copy the field from the outer_ctx to ctx.  Since this is done
    (properly) in the only function where this field is actually used
    (in function scan_omp_for) and the field is being initialized to zero
    during the struct allocation, there is no need to attempt to do
    anything to this field in new_omp_context. Thus this commit
    removes any assignment to the field from new_omp_context.

    2020-04-21  Frederik Harwath  <frede...@codesourcery.com>

            PR other/94629
            * gcc/omp-low.c (new_omp_context): Remove assignments to
            ctx->outer_reduction_clauses and ctx->local_reduction_clauses.

    Reviewed-by: Thomas Schwinge  <tho...@codesourcery.com>

Reply via email to