On Mon, Dec 30, 2019 at 07:24:08PM +0530, Ayush Mittal wrote:
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,7 @@
> +2019-12-30 Ayush Mittal <[email protected]>
> +
> + * libgomp: Add destructor to delete runtime env keys
This line should have been instead something like:
* oacc-init.c (goacc_runtime_deinitialize): New function.
and it should go into libgomp/ChangeLog rather than toplevel ChangeLog.
Otherwise, LGTM.
Do you have anybody that can commit it for you, or do you want me to commit
it for you?
> 2019-12-20 Jerome Lambourg <[email protected]>
>
> * MAINTAINERS (write_after_approval): Add myself.
> diff --git a/libgomp/oacc-init.c b/libgomp/oacc-init.c
> index 487a2cca61f..6aa5fd297d6 100644
> --- a/libgomp/oacc-init.c
> +++ b/libgomp/oacc-init.c
> @@ -858,6 +858,15 @@ goacc_runtime_initialize (void)
> goacc_host_init ();
> }
>
> +static void __attribute__((destructor))
> +goacc_runtime_deinitialize (void)
> +{
> +#if !(defined HAVE_TLS || defined USE_EMUTLS)
> + pthread_key_delete (goacc_tls_key);
> +#endif
> + pthread_key_delete (goacc_cleanup_key);
> +}
> +
> /* Compiler helper functions */
>
> attribute_hidden void
Jakub
