https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91962
--- Comment #7 from Marek Polacek <mpolacek at gcc dot gnu.org> --- Author: mpolacek Date: Mon Nov 18 16:39:24 2019 New Revision: 278416 URL: https://gcc.gnu.org/viewcvs?rev=278416&root=gcc&view=rev Log: PR c++/91962 - ICE with reference binding and qualification conversion. When fixing c++/91889 (r276251) I was assuming that we couldn't have a ck_qual under a ck_ref_bind, and I was introducing it in the patch and so this + if (next_conversion (convs)->kind == ck_qual) + { + gcc_assert (same_type_p (TREE_TYPE (expr), + next_conversion (convs)->type)); + /* Strip the cast created by the ck_qual; cp_build_addr_expr + below expects an lvalue. */ + STRIP_NOPS (expr); + } in convert_like_real was supposed to handle it. But that assumption was wrong as this test shows; here we have "(int *)f" where f is of type long int, and we're converting it to "const int *const &", so we have both ck_ref_bind and ck_qual. That means that the new STRIP_NOPS strips an expression it shouldn't have, and that then breaks when creating a TARGET_EXPR. So we want to limit the stripping to the new case only. This I do by checking need_temporary_p, which will be 0 in the new case. Yes, we can set need_temporary_p when binding a reference directly, but then we won't have a qualification conversion. It is possible to have a bit-field, convert it to a pointer, and then convert that pointer to a more-qualified pointer, but in that case we're not dealing with an lvalue, so gl_kind is 0, so we won't enter this block in reference_binding: 1747 if ((related_p || compatible_p) && gl_kind) * call.c (convert_like_real) <case ck_ref_bind>: Check need_temporary_p. * g++.dg/cpp0x/ref-bind7.C: New test. Added: trunk/gcc/testsuite/g++.dg/cpp0x/ref-bind7.C Modified: trunk/gcc/cp/ChangeLog trunk/gcc/cp/call.c trunk/gcc/testsuite/ChangeLog
