https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90142

            Bug ID: 90142
           Summary: contrib/download_prerequisites uses test ==
           Product: gcc
           Version: 9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: roland.illig at gmx dot de
  Target Milestone: ---

Since download_prerequisites is (probably) run via /bin/sh, it should use
portable shell programming constructs:

--- contrib/download_prerequisites.orig 2017-04-11 16:34:07.000000000 +0000
+++ contrib/download_prerequisites
@@ -122,7 +122,7 @@ md5_check() {
   md5_checksum_output=$(md5 -r "${file_to_check}")
   # Grab the text before the first space
   md5_checksum_detected="${md5_checksum_output%% *}"
-  [ "${md5_checksum_expected}" == "${md5_checksum_detected}" ] \
+  [ "${md5_checksum_expected}" = "${md5_checksum_detected}" ] \
     || die "Cannot verify integrity of possibly corrupted file
${file_to_check}"
   echo "${file_to_check}: OK"
 }

Reply via email to