https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88879

--- Comment #6 from Andrey Belevantsev <abel at gcc dot gnu.org> ---
(In reply to Alexander Monakov from comment #4)
> Thanks. This broke when the patch for PR 85458 was applied, and Andreas
> raised it on the gcc-patches thread:
> https://gcc.gnu.org/ml/gcc-patches/2018-09/msg00128.html
> 
> Soon after that, the HP-PA adjust_priority target hook was removed, making
> the sel-sched change unnecessary. Therefore, my recommendation is to revert
> the sel-sched patch, or remove the new assert as Andreas has suggested.
> Andrey, which approach would you prefer?
> 
> It's also possible to implement Jeff's suggestion and clamp negative
> priorities to zero in create_speculation_check, but that may turn out to be
> insufficient if there is other code producing negative priority values.

I would try to avoid negative priorities if possible. It looks they could only
come from the adjust_priority hook or from create_speculation_check.  If the
former is now impossible then maybe just fix the latter?

Reply via email to