https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87385

            Bug ID: 87385
           Summary: -Wmisleading-indentation shouldn't warn for labels
           Product: gcc
           Version: 7.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: lennox at cs dot columbia.edu
  Target Milestone: ---

Created attachment 44736
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=44736&action=edit
Test program that triggers the warning.

In the attached code, gcc gives a misleading-indentation warning for the label
in

        if (input != NULL) free_subobj2(ret->obj2);  FAIL3:

Since the if statement doesn't control whether a goto can actually go to the
label, I don't see how this indentation can be misleading.

$ gcc -Wall -c misleading-indentation-label.c
misleading-indentation-label.c: In function ‘alloc_object’:
misleading-indentation-label.c:46:2: warning: this ‘if’ clause does not
guard... [-Wmisleading-indentation]
  if (input != NULL) free_subobj2(ret->obj2);  FAIL3:
  ^~
misleading-indentation-label.c:46:47: note: ...this statement, but the latter
is misleadingly indented as if it were guarded by the ‘if’
  if (input != NULL) free_subobj2(ret->obj2);  FAIL3:
                                               ^~~~~

$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/7/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 7.3.0-16ubuntu3'
--with-bugurl=file:///usr/share/doc/gcc-7/README.Bugs
--enable-languages=c,ada,c++,go,brig,d,fortran,objc,obj-c++ --prefix=/usr
--with-gcc-major-version-only --with-as=/usr/bin/x86_64-linux-gnu-as
--with-ld=/usr/bin/x86_64-linux-gnu-ld --program-suffix=-7
--program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id
--libexecdir=/usr/lib --without-included-gettext --enable-threads=posix
--libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu
--enable-libstdcxx-debug --enable-libstdcxx-time=yes
--with-default-libstdcxx-abi=new --enable-gnu-unique-object
--disable-vtable-verify --enable-libmpx --enable-plugin --enable-default-pie
--with-system-zlib --with-target-system-zlib --enable-objc-gc=auto
--enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64
--with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic
--enable-offload-targets=nvptx-none --without-cuda-driver
--enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu
--target=x86_64-linux-gnu
Thread model: posix
gcc version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)

Reply via email to