https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86746

            Bug ID: 86746
           Summary: Libraries' configure uses config-ml.in whether
                    multilib is being used or not
           Product: gcc
           Version: 7.3.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: John.Ericson at Obsidian dot Systems
  Target Milestone: ---

Created attachment 44469
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=44469&action=edit
Patch adding `if...fi` to config/multi.m4 to solve issue

[I discovered this when working on libatomic. I didn't see that as an option so
I choose libstdc++ as the nearest one. The issue affects multiple libraries,
anyways.]

This poses no problem during a number build when everything is built together,
but does cause headache when building the libraries separately. [I use my
package manager to achieve what multilib does for distro consistency, and
easier tweaking of library implementations.]

There's no good reason to rely on multilib variables when the feature isn't
being used, so this can also be viewed as a general cleanup to not accidentally
depend on data for no reason, in case separate building of libraries is not
compelling.

Notes on the patch:

 - I'm not quite sure what the intended indentation of files like this is. I
tried to do something that seemed reasonable me while not changing code
unnecessarily. 

 - I switched to AC_CONFIG_COMMANDS because the old one was deprecated (in the
older version of GNU Autoconf that GCC uses, not just the latest).

 - I wrote and tested with patch against 7.3.0, but `git log` tells me the
value hasn't changed since.

Reply via email to