https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82240

--- Comment #9 from David Binderman <dcb314 at hotmail dot com> ---
(In reply to Andrew Pinski from comment #7)
> but atom.md could be improved to just say:
> That is get rid of the check for memory attr on the second case.

I tried out your change and it appears to remove the first warning.

Here are the relevant lines from the build:

$ grep "warning:.*Wlogical-op" mk.out 
../../trunk/gcc/config/i386/i386.md:21228:36: warning: logical ‘or’ of
collectively exhaustive tests is always true [-Wlogical-op]
$ 

More detail:

../../trunk/gcc/config/i386/i386.md: In function ‘int
insn_default_latency_slm(rtx_insn*)’:
../../trunk/gcc/config/i386/i386.md:21228:36: warning: logical ‘or’ of
collectively exhaustive tests is always true [-Wlogical-op]

This seems to be somewhere near source code in file insn-latencytab.c

    case 5028:  /* loaddi_via_sse */
    case 5029:  /* storedi_via_sse */
      extract_insn_cached (insn);
      if (((cached_type = get_attr_type (insn)) == TYPE_OTHER) && (!
((cached_atom_unit = get_attr_atom_unit (insn)) == ATOM_UNIT_JEU)))
        {

Reply via email to