https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80763
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marxin at gcc dot gnu.org
--- Comment #8 from Martin Liška <marxin at gcc dot gnu.org> ---
Created attachment 41987
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=41987&action=edit
Patch candidate
I wrongly pasted 2 patches to a different PR.
Adding patch candidate that changes cgraph_node::verify_node that verifies
global.inlined_to && same_comdat_group. It believe proper fix is to verify that
node should live in a same comdat group (if belongs to any).
Honza's reply:
OK, so now the tests passes when inline clone is either in no comdat group list
(even if function inlined to is in one) or if the comdat groups are the same.
Does it fail when we test that comdats groups are always the same? It seems
iffy to allow silently both. I guess both variants are fine, but lets pick one
of them. Perhaps we want only to remove node from comdat group list while
inlining it.
My reply:
I'm going to test it whether more strict test will survive.
Honza
