https://gcc.gnu.org/bugzilla/show_bug.cgi?id=72833
--- Comment #10 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> --- > --- Comment #9 from Bernd Edlinger <bernd.edlinger at hotmail dot de> --- >> In progress. Two comments: >> >> * Why the fixincl.tpl change? Is this necessary with upstream autogen >> or only due to some Ubuntu-local change? Bruce will probably know >> when he reviews the patch, though. >> > > Don't know, all I know from autogen is that it is not easy to build locally. > > So far I never encountered any difficulties with it under linux. > > I tried different settings, and it looks like the code that is > enabled for autogen >= 5.18, but apparently the 5.18 behaves > like the old version, so this is probably not a back-port of a > new feature. My guess is that simply the version should be > checked for autogen >= 5.18.1 ? Just leave it as it for Bruce to decide. >> * Your comment >> >> /* >> * Before Mac OS X 10.7 <i386/setjmp.h> doesn't mark longjump noreturn. >> */ >> >> is wrong, however: even the 10.7 <i386/setjmp.h> does lack the >> annotation, and in 10.8 (as I'd seen in 10.11 and 10.12) the >> declaration has moved to <setjmp.h> and is properly annotated. I >> suspect the bypass can just go, even if it does no harm. >> > > Then I change it to "Before Mac OS X 10.8" Not fully right either: there is no <i386/setjmp.h> in 10.8+ ;-) >> You can find the 10.8 <setjmp.h> at >> >> http://opensource.apple.com/source/Libc/Libc-825.24/include/setjmp.h >> >> while the 10.7.5 one (the latest 10.7 update) is at >> >> http://opensource.apple.com/source/Libc/Libc-763.13/include/setjmp.h >> >> and the corresponding <i386/setjmp.h> at >> >> http://opensource.apple.com/source/xnu/xnu-1699.32.7/bsd/i386/setjmp.h >> >> Rainer > > > BTW: I noticed that the fix-rule misses the siglongjmp, > because the parameter is sigjmp_buf. True: the Solaris fix missed this, probably because the issue never came up. The Mac OS X 10.8+ <setjmp.h> has the annotation, so it's probably best to fix both while you're at it. > Do you want an updated patch with these changes? Can't hurt: I'll also run a i686-apple-darwin11 bootstrap which I can use to verify it. Rainer
