https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67215
--- Comment #7 from hjl at gcc dot gnu.org <hjl at gcc dot gnu.org> --- Author: hjl Date: Tue Oct 27 14:29:31 2015 New Revision: 229444 URL: https://gcc.gnu.org/viewcvs?rev=229444&root=gcc&view=rev Log: Properly handle -fno-plt in ix86_expand_call prepare_call_address in calls.c is the wrong place to handle -fno-plt. We shoudn't force function address into register and hope that load function address via GOT and indirect call via register will be folded into indirect call via GOT, which doesn't always happen. Also non-PIC case can only be handled in backend. Instead, backend should expand external function call into indirect call via GOT for -fno-plt. This patch reverts -fno-plt in prepare_call_address and handles it in ix86_expand_call. Other backends may need similar changes to support -fno-plt. Alternately, we can introduce a target hook to indicate whether an external function should be called via register for -fno-plt so that i386 backend can disable it in prepare_call_address. gcc/ PR target/67215 * calls.c (prepare_call_address): Don't handle -fno-plt here. * config/i386/i386.c (ix86_expand_call): Generate indirect call via GOT for -fno-plt. Support indirect call via GOT for x32. * config/i386/predicates.md (sibcall_memory_operand): Allow GOT memory operand. gcc/testsuite/ PR target/67215 * gcc.target/i386/pr67215-1.c: New test. * gcc.target/i386/pr67215-2.c: Likewise. * gcc.target/i386/pr67215-3.c: Likewise. Added: trunk/gcc/testsuite/gcc.target/i386/pr67215-1.c trunk/gcc/testsuite/gcc.target/i386/pr67215-2.c trunk/gcc/testsuite/gcc.target/i386/pr67215-3.c Modified: trunk/gcc/ChangeLog trunk/gcc/calls.c trunk/gcc/config/i386/i386.c trunk/gcc/config/i386/predicates.md trunk/gcc/testsuite/ChangeLog
