https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66521

--- Comment #15 from Eric Gallager <egall at gwmail dot gwu.edu> ---
(In reply to ctice from comment #14)
> Author: ctice
> Date: Wed Aug 12 15:40:11 2015
> New Revision: 226820
> 
> URL: https://gcc.gnu.org/viewcvs?rev=226820&root=gcc&view=rev
> Log:
> Fix warnings when bootstrapping on darwin with vtable verification enabled.
> 
> libstdc++-v3/ChangeLog:
> 
> 2015-08-11  Caroline Tice <cmt...@google.com>
> 
>         PR 66521, Contributed by Eric Gallager
>         * acinclude.m4 (VTV_CXXLINKFLAGS): Make this variable OS-specific,
> and
>         fix the rpath flag to work properly for darwin.
>         * configure: Regenerated.
> 
> 
> Modified:
>     trunk/libstdc++-v3/ChangeLog
>     trunk/libstdc++-v3/acinclude.m4
>     trunk/libstdc++-v3/configure

Thanks for committing this! Just a note re: the commit message, though: I wrote
the patch to fix the error from comment #8; I'd assume the warnings I mentioned
in comment #11 and comment #12 would still be an issue on darwin 10, though...
I tried testing to confirm, but I'm actually currently knocked back to darwin 9
here, which has an older cctools and assembler, so now I error out earlier with
an assembler error:

Making all in c++98
make[6]: Entering directory
`/private/var/root/gcc-git/my_oddly_named_builddir/i386-apple-darwin9.8.0/libstdc++-v3/src/c++98'
/bin/sh ../../libtool --tag CXX --tag disable-shared   --mode=compile
/var/root/gcc-git/my_oddly_named_builddir/./gcc/xgcc -shared-libgcc
-B/var/root/gcc-git/my_oddly_named_builddir/./gcc -nostdinc++
-L/var/root/gcc-git/my_oddly_named_builddir/i386-apple-darwin9.8.0/libstdc++-v3/src
-L/var/root/gcc-git/my_oddly_named_builddir/i386-apple-darwin9.8.0/libstdc++-v3/src/.libs
-L/var/root/gcc-git/my_oddly_named_builddir/i386-apple-darwin9.8.0/libstdc++-v3/libsupc++/.libs
-B/usr/local/i386-apple-darwin9.8.0/bin/
-B/usr/local/i386-apple-darwin9.8.0/lib/ -isystem
/usr/local/i386-apple-darwin9.8.0/include -isystem
/usr/local/i386-apple-darwin9.8.0/sys-include   
-I/var/root/gcc-git/libstdc++-v3/../libgcc
-I/var/root/gcc-git/my_oddly_named_builddir/i386-apple-darwin9.8.0/libstdc++-v3/include/i386-apple-darwin9.8.0
-I/var/root/gcc-git/my_oddly_named_builddir/i386-apple-darwin9.8.0/libstdc++-v3/include
-I/var/root/gcc-git/libstdc++-v3/libsupc++   -std=gnu++98 -prefer-pic
-D_GLIBCXX_SHARED -fno-implicit-templates -fvtable-verify=std
-Wl,-u,_vtable_map_vars_start -Wl,-u,_vtable_map_vars_end -Wall -Wextra
-Wwrite-strings -Wcast-qual -Wabi  -fdiagnostics-show-location=once 
-fvisibility-inlines-hidden -ffunction-sections -fdata-sections 
-frandom-seed=bitmap_allocator.lo -g -O2  -c -o bitmap_allocator.lo
../../../../../libstdc++-v3/src/c++98/bitmap_allocator.cc
libtool: compile:  /var/root/gcc-git/my_oddly_named_builddir/./gcc/xgcc
-shared-libgcc -B/var/root/gcc-git/my_oddly_named_builddir/./gcc -nostdinc++
-L/var/root/gcc-git/my_oddly_named_builddir/i386-apple-darwin9.8.0/libstdc++-v3/src
-L/var/root/gcc-git/my_oddly_named_builddir/i386-apple-darwin9.8.0/libstdc++-v3/src/.libs
-L/var/root/gcc-git/my_oddly_named_builddir/i386-apple-darwin9.8.0/libstdc++-v3/libsupc++/.libs
-B/usr/local/i386-apple-darwin9.8.0/bin/
-B/usr/local/i386-apple-darwin9.8.0/lib/ -isystem
/usr/local/i386-apple-darwin9.8.0/include -isystem
/usr/local/i386-apple-darwin9.8.0/sys-include
-I/var/root/gcc-git/libstdc++-v3/../libgcc
-I/var/root/gcc-git/my_oddly_named_builddir/i386-apple-darwin9.8.0/libstdc++-v3/include/i386-apple-darwin9.8.0
-I/var/root/gcc-git/my_oddly_named_builddir/i386-apple-darwin9.8.0/libstdc++-v3/include
-I/var/root/gcc-git/libstdc++-v3/libsupc++ -std=gnu++98 -D_GLIBCXX_SHARED
-fno-implicit-templates -fvtable-verify=std -Wl,-u,_vtable_map_vars_start
-Wl,-u,_vtable_map_vars_end -Wall -Wextra -Wwrite-strings -Wcast-qual -Wabi
-fdiagnostics-show-location=once -fvisibility-inlines-hidden
-ffunction-sections -fdata-sections -frandom-seed=bitmap_allocator.lo -g -O2 -c
../../../../../libstdc++-v3/src/c++98/bitmap_allocator.cc  -fno-common -DPIC
-D_GLIBCXX_SHARED -o bitmap_allocator.o
/var/tmp//ccxrd6Je.s:15603:FATAL:symbol:
__ZN4_VTVIN9__gnu_cxx24__concurrence_wait_errorEE12__vtable_mapE can't be a
weak_definition (currently only supported in section of type coalesced)
make[6]: *** [bitmap_allocator.lo] Error 1
make[6]: Leaving directory
`/private/var/root/gcc-git/my_oddly_named_builddir/i386-apple-darwin9.8.0/libstdc++-v3/src/c++98'
make[5]: *** [all-recursive] Error 1
make[5]: Leaving directory
`/private/var/root/gcc-git/my_oddly_named_builddir/i386-apple-darwin9.8.0/libstdc++-v3/src'
make[4]: *** [all-recursive] Error 1
make[4]: Leaving directory
`/private/var/root/gcc-git/my_oddly_named_builddir/i386-apple-darwin9.8.0/libstdc++-v3'
make[3]: *** [all] Error 2
make[3]: Leaving directory
`/private/var/root/gcc-git/my_oddly_named_builddir/i386-apple-darwin9.8.0/libstdc++-v3'
make[2]: *** [all-stage1-target-libstdc++-v3] Error 2
make[2]: Leaving directory `/private/var/root/gcc-git/my_oddly_named_builddir'
make[1]: *** [stage1-bubble] Error 2
make[1]: Leaving directory `/private/var/root/gcc-git/my_oddly_named_builddir'
make: *** [all] Error 2

I get the feeling it could actually be related to those linker warnings I
mentioned previously?

Reply via email to