[Bug lto/60567] [4.9 Regression] lto1 ICE in add_symbol_to_partition, at lto/lto-partition.c:233 with -fno-use-linker-plugin

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60567

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason at redhat dot com

--- Comment #15 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
This patch fixes the ICE by copying forced_by_abi as part of cgraph fixup in
ipa visibility.  I would like Jason to comment on this. I think fix at C++ FE
side would be more appropriate if the thunk is indeed keyed.

If not, I will update partitinoning predicate to always iterate the whole group
and see if any of symbols is keyed.

Index: ipa.c
===================================================================
--- ipa.c       (revision 209170)
+++ ipa.c       (working copy)
@@ -1032,6 +1032,7 @@ function_and_variable_visibility (bool w
                                   == DECL_COMDAT_GROUP (decl_node->decl));
              gcc_checking_assert (node->same_comdat_group);
            }
+         decl_node->forced_by_abi = node->forced_by_abi;
          if (DECL_EXTERNAL (decl_node->decl))
            DECL_EXTERNAL (node->decl) = 1;
        }