http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53042

--- Comment #3 from Jan Hubicka <hubicka at ucw dot cz> 2012-04-19 16:03:09 UTC 
---
Thanks for working on this.  The patch is pre-approved if it passes testing.

The new symtab verifier is just old cgraph verifier and only change is that
we now do same testing for variables, too.  I do not see why COMDAT_GROUP gets
right on functions and not on variables.  It seems like latent issue here:

Index: decl2.c
===================================================================
--- decl2.c    (revision 186576)
+++ decl2.c    (working copy)
@@ -1894,7 +1894,7 @@ maybe_emit_vtables (tree ctype)
      actually marking the variable as written.  */
       if (flag_syntax_only)
     TREE_ASM_WRITTEN (vtbl) = 1;
-      else if (DECL_COMDAT (vtbl))
+      else if (DECL_ONE_ONLY (vtbl))
     {
       current = varpool_node (vtbl);
       if (last)

At least the corresponding callgraph code is using this test.  David, does this
passes the original testing?

Honza

Reply via email to