http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51033
--- Comment #13 from Manuel López-Ibáñez <manu at gcc dot gnu.org> 2012-04-17 12:13:02 UTC --- (In reply to comment #12) > On the other hand, here I am copying a small block of code in the middle of a > function. Making just that paragraph common wouldn't make much sense imho. > Factoring most of (cp_)build_array_ref might make sense, but requires someone > with a better understanding of the FEs, because there are slight differences > that may or may not be relevant. Something is better than nothing. I respectfully disagree, there are more than 10 lines of code there. If some change is ever required in those and the code is not shared, only one version will be changed. You can call the function vector_to_underlying_pointer_type() or something like that. Then you don't even need a comment.