http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228
Tobias Burnus <burnus at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |burnus at gcc dot gnu.org
--- Comment #8 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-02-13
16:17:21 UTC ---
(In reply to comment #2)
> My regexp explicitly forbirds / right before PR.... but I cannot remember why:
> qr/(?<!\/)\b(pr(?:\s*|\s+\S+\/)(\d+)(?:\s+comment\s+(\d+))?)/i
> I will drop this restriction, but will bring it back if it appears there was a
> good reason to do so. :)
Best would be a pattern, which only prohibits "http(s):"[nonwhitespace]/PR".
(In reply to comment #7)
> Ah, right! That was the reason I explicitly excluded / right before PR. So I
> guess the problem described in comment 0 is minor enough to let it unfixed.
> Any
> objection?
For the issue of comment 0, allowing "[0-9]/PR" should probably be safe.
However, one also finds: "middle-end/PR1234" (for those which mistype "PR
middle-end/1234").
Regarding comment 0, how about such a pattern:
qr/(?<!\D/)\b(pr(?:\s*|\s+\S+\/)(\d+)(?:\s+comment\s+(\d+))?)/i
^^
Plus a comment, which explains why one has that pattern ...
