[Bug fortran/50070] Segmentation fault at size_binop_loc in fold-const.c

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50070

--- Comment #10 from janus at gcc dot gnu.org 2011-08-16 09:19:07 UTC ---
Here is a patch which rejects the test case with a different error message than
comment #6:


Index: gcc/fortran/resolve.c
===================================================================
--- gcc/fortran/resolve.c    (revision 177779)
+++ gcc/fortran/resolve.c    (working copy)
@@ -10169,15 +10169,22 @@ resolve_fl_variable (gfc_symbol *sym, int mp_flag)

       if (!gfc_is_constant_expr (e)
       && !(e->expr_type == EXPR_VARIABLE
-           && e->symtree->n.sym->attr.flavor == FL_PARAMETER)
-      && sym->ns->proc_name
-      && (sym->ns->proc_name->attr.flavor == FL_MODULE
-          || sym->ns->proc_name->attr.is_main_program)
-      && !sym->attr.use_assoc)
+           && e->symtree->n.sym->attr.flavor == FL_PARAMETER))
     {
-      gfc_error ("'%s' at %L must have constant character length "
-             "in this context", sym->name, &sym->declared_at);
-      return FAILURE;
+      if (!sym->attr.use_assoc && sym->ns->proc_name
+          && (sym->ns->proc_name->attr.flavor == FL_MODULE
+          || sym->ns->proc_name->attr.is_main_program))
+        {
+          gfc_error ("'%s' at %L must have constant character length "
+            "in this context", sym->name, &sym->declared_at);
+          return FAILURE;
+        }
+      if (sym->attr.in_common)
+        {
+          gfc_error ("COMMON variable '%s' at %L must have constant "
+             "character length", sym->name, &sym->declared_at);
+          return FAILURE;
+        }
     }
     }