http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47324

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #22 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-02-09 
08:23:36 UTC ---
The #c14 dwarf2out.c hunks look reasonable, though I'd probably just declare
the r variable inside of the if block (i.e.
...
    {
      unsigned long r
        = DWARF2_FRAME_REG_OUT (cfi->dw_cfi_oprnd1.dw_cfi_reg_num, for_eh);
...
).  And for consistency DWARF2_FRAME_REG_OUT should be probably used in
output_cfa_loc_raw too, just with unconditional 1 as for_eh.

That said, I very much doubt r157762 did anything here, for this purpose it
just swapped the two operands, but the code wasn't using DWARF2_FRAME_REG_OUT
before that check in either.  r157762 would only matter in output_cfis which is
called when doing hot/cold section partitioning (which eh-alloca-1.C is not).

Reply via email to