http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46585

--- Comment #6 from Alexander Monakov <amonakov at gcc dot gnu.org> 2010-11-24 
14:38:47 UTC ---
(In reply to comment #5)
> +  nop_pattern = gen_rtx_CONST_INT (VOIDmode, -1);
> 
> You could just use
>   nop_pattern = constm1_rtx;
> or just #define nop_pattern constm1_rtx

Thanks.

> But, when you change nop_pattern, then INSN_NOP_P () won't match normal nops,
> just your new ones.  Is that desirable?

Yes, that's exactly what we need, because "nops" are used as special markers. 
I don't think normal nops are any different to other normal insns from the
scheduler POV; therefore, there's no need to match normal nops.

However, the name INSN_NOP_P does not have anything to do with the real pattern
after this patch ;)

> Perhaps you want instead to define INSN_NOP_P as CONST_INT_P (PATTERN (X))
> (at least, where you want to match any nops, including your special ones, 
> where
> you want to match just your special ones, PATTERN (X) == nop_pattern is
> correct.

Per the above, no, we don't have a need for that.

Reply via email to