------- Comment #4 from davek at gcc dot gnu dot org 2009-12-17 19:58 -------
(In reply to comment #2)
> Created an attachment (id=19339)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19339&action=view) [edit]
> updated patch to allow specification of -static-libstdc++ on the CL while
> generating PCH
>
The maintainers will probably point out you've got a few bits of stray
formatting there (relative to the gcc coding standard); for example here:
- {
- library = library >= 0 ? 2 : library;
- args[i] |= SKIPOPT;
- }
+ {
+ library |= library >= 0 ? 2 : library;
+ args[i] |= SKIPOPT;
+ }
you've replaced a leading TAB by eight spaces, where the coding standard wants
all groups of 8 spaces at the start of a line to be real hard TABs. That may
be something you'll have to fix elsewhere too, I guess your editor probably
gave you spaces for indentation throughout. The only other nit I noticed was:
- if (library == 0)
+ if ( library >= 0 && (library & 1) == 0)
an excess space before library there that you might as well tidy up while
you're at it.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41596
