------- Comment #14 from howarth at nitro dot med dot uc dot edu 2008-08-04
00:53 -------
The complete make check from the boot strap is still running but the g++
stackalign failures have been reduced down to just...
FAIL: g++.dg/torture/stackalign/eh-alloca-1.C -O3 -g execution test
FAIL: g++.dg/torture/stackalign/eh-vararg-1.C -O3 -g execution test
FAIL: g++.dg/torture/stackalign/eh-vararg-2.C -O3 -g execution test
FAIL: g++.dg/torture/stackalign/throw-1.C -O3 -g execution test
FAIL: g++.dg/torture/stackalign/throw-2.C -O3 -g execution test
FAIL: g++.dg/torture/stackalign/throw-3.C -O3 -g execution test
FAIL: g++.dg/torture/stackalign/eh-alloca-1.C -O3 -g execution test
FAIL: g++.dg/torture/stackalign/eh-vararg-1.C -O3 -g execution test
FAIL: g++.dg/torture/stackalign/eh-vararg-2.C -O3 -g execution test
FAIL: g++.dg/torture/stackalign/throw-1.C -O3 -g execution test
FAIL: g++.dg/torture/stackalign/throw-2.C -O3 -g execution test
FAIL: g++.dg/torture/stackalign/throw-3.C -O3 -g execution test
Without your patch these failed at all optimization levels. I noticed we still
have many
instances of STACK_BOUNDARY / BITS_PER_UNIT in the patched sources in the gcc
subdirectory...
calls.c:#define STACK_BYTES (PREFERRED_STACK_BOUNDARY / BITS_PER_UNIT)
calls.c: & (PREFERRED_STACK_BOUNDARY / BITS_PER_UNIT - 1)));
cfgexpand.c: int align = PREFERRED_STACK_BOUNDARY / BITS_PER_UNIT;
cfgexpand.c: HOST_WIDE_INT align = PREFERRED_STACK_BOUNDARY /
BITS_PER_UNIT;
explow.c: int align = PREFERRED_STACK_BOUNDARY / BITS_PER_UNIT;
explow.c: int align = PREFERRED_STACK_BOUNDARY / BITS_PER_UNIT;
explow.c: % (PREFERRED_STACK_BOUNDARY / BITS_PER_UNIT)));
function.c:#define STACK_BYTES (STACK_BOUNDARY / BITS_PER_UNIT)
function.c: frame_alignment = PREFERRED_STACK_BOUNDARY / BITS_PER_UNIT;
tree-nested.c: size += ((align/BITS_PER_UNIT) - 1) &
-(STACK_BOUNDARY/BITS_PER_UNIT);
Shouldn't these universally be changed to be UNITS_PER_WORD instead?
Jack
ps All the stackalign failures in the gcc section are gone now.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37012
