------- Comment #20 from manu at gcc dot gnu dot org 2008-07-21 16:32 ------- (In reply to comment #19) > Okay, so the two patches are now committed to trunk in changesets > r137716 and r137721. > > However, given the nature of this enhancement request, I think it will take > some on going work to have perfect column number information in the C++ front > end when using -fshow-column and eventually enabling that option by default. >
Dodji, thanks for tackling this issue. In the long run, all diagnostic functions should take a location parameter. Currently there is a patch to add warning_at() by Rafael Espindola. However, the goal is to replace warning/error/pedwarn/etc by versions that take a location as the first parameter, thus making obsolote the use of %H. I see that you are adding a lot of %H to the code, so I was wondering whether wouldn't it be better to add instead error_at, pedwarn_at and etc. In the future it will be easier to change those to just error, pedwarn and etc, than to change all those %H. -- manu at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |manu at gcc dot gnu dot org http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31754