------- Comment #12 from rask at gcc dot gnu dot org 2007-10-28 14:00 -------
In reply to comment #11:
> How many times do I have to say this is bad for most RISC targets (hosts)?
I don't particularily care how many times you say it. Show some code (which
works) and/or show some timings (of code that works).
> Really if the type being is used is wrong, they should be changed
> rather than changing to use var-args.
Will you please look at the code? You have gen_movsi() with 2 arguments and
gen_addsi3() with 3 arguments. Given that they are put into a table as a
function of type insn_gen_fn and called as such through the table (see the
GEN_FCN() macro in optabs.h and the table definition in recog.h), the
function definition has to match. If it doesn't, all bets are off as to what
arguments the function receives. We have gen_* functions taking 0, 1, 2, 3, ...
arguments and with GCC being designed the way it is, they need to be
prototyped and defined with the same arguments.
You are most definitely welcome to post some non-varargs code which works.
You are most definitely also welcome to time it against my patches.
--
rask at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to fail| |4.3.0
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12081
