------- Comment #39 from manu at gcc dot gnu dot org 2007-03-24 00:28 ------- (In reply to comment #37) > The tests in gcc.dg/dfp are only run for a compiler configured with > --enable-decimal-float; the diagnostics tests there often just have "error" or > "warning" as the expression to match. I have patches for those and for most > of > the tests in gcc.dg/cpp. I'm planning to submit patches with batches of > fixes, > ask for comments, and then just check them in. The results are no different > and they can be changed back later. I recommend that you do the same, Manuel, > and copy me so I can approve them, since I've been behind in keeping up with > gcc-patches recently.
I built always with --enable-decimal-float. We are duplicating work :( First, you don't need to fix those testcases that use "warning" or "error" as the expression to match, since those can be fixed automatically by the script that I have attached and are guaranteed to work. Moreover, until the final patch is in, those are guaranteed to keep working, so they should be the last ones to be committed. (But it is good to fix them in your working copy using my script so they don't distract you from the real failures). The testcases that we should really fix (see the list that I have attached) are: 1) Those where the wrong directive is used. 2) Those that use a dg-warning or dg-error to match something that is neither a warning nor an error. 3) Those that fail for some other reason. And (3) are the most important because they typically mean that we need to tweak something in the current patch. Two failures of type (3) are gcc/testsuite/gcc.dg/20041213-1.c and gcc/testsuite/gfortran.dg/badline.f Could you look why those two fail? I am sure that if we fix the patch to match correctly those testcases, then a bunch of other failures will go away as well. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25241
