------- Additional Comments From ebotcazou at gcc dot gnu dot org 2005-05-03 11:35 ------- > Use __FLT_MIN__ etc. since <float.h> may not be included.
Of course. > For a good fix we'll want to add built-in functions compatible with the > Solaris header and remove the relevant fixes, and those would test the > bits of the representation appropriately, but for now I think __FLT_MIN__ > is the right approach and the fixes could more suitably go on 4.0 branch > than new built-in functions. Agreed. I'll open an enhancement PR for the missing builtins. > We have a functional __builtin_isnan, there is no need to fix that > particular definition. Right, but it is type-dependent so I guess we have to play the sizeof game. I'm going to attach a revised version. Does it look OK to you? If so, I'll write tests and run them on SPARC (I don't have access to i386-pc-solaris2.10) before translating it into a fixinclude patch. Note that I'd like to have a fix for the 3.4 branch too, and we have neither __builtin_isnan nor __builtin_signbit on that branch. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19933
