Argh, sorry, small mistake in the one for freetype2 . Here is the correct
version. I am sure you know why/how the mistake happened :-), if you try to
apply the older one in that 3.
On Friday, 7 July 2023 at 20:34:38 BST, Hin-Tak Leung
<[email protected]> wrote:
Hi Werner,
3 patches, one for freetype2, and two for freetype2-demos (the rsvg one is a
re-post).
None of them are anything critical. I think I'd really like the rsvg one to go
in, if only to stay sync with the corresponding python code in
freetype-py/examples. I am also very sure you do not want it to go in as
currently is; you most likely want to code the same idea in a different way -
but it is a start.
The freetype2 one is a discovery from rebasing the Fontval diff. The 3rd one in
ft2-demos is sort of in the same area, and recent thoughts on RendererHook's
and DebugHook's signatures.
One thing I'd like to suggest, if FreeType 3 is ever happening, is for the
DebugHook to move a bit earlier in the Library struct, and especially before
any of the variable/adjustable sized sub-structures. It makes implementing
interactive font debuggers / font editors with FreeType 3, and things like
Fontval, in a non-C language, a bit easier.
Yes, I briefly thought of expanding freetype-py, and re-writing ttdebug in
python. It cannot happen (easily... alway a matter of how much pain/trouble one
wants to bear...) for the reason above :-). And same with FontVal-RX - the next
stage of FontVal, with dual freetype and microsoft backends.
Hin-Tak
From 2687e0378f8798b0cc262362ed5f942e3e693961 Mon Sep 17 00:00:00 2001
From: Hin-Tak Leung <[email protected]>
Date: Fri, 7 Jul 2023 19:24:48 +0100
Subject: [PATCH] * src/truetype/ttgload.c (TT_Hint_Glyph): More mostly
cosmetic update.
This is a follow-up to 49c74ac021f8139e83bbd65df75217d0de284eea,
which creates a new local variable "exec = loader->exec", and
shortening a lot of "loader->exec". This commit does two more
such changes missed in that first commit.
Signed-off-by: Hin-Tak Leung <[email protected]>
---
src/truetype/ttgload.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/truetype/ttgload.c b/src/truetype/ttgload.c
index 5f15a7f4d..d538e8ee8 100644
--- a/src/truetype/ttgload.c
+++ b/src/truetype/ttgload.c
@@ -820,7 +820,7 @@
FT_ARRAY_COPY( zone->org, zone->cur, zone->n_points );
/* Reset graphics state. */
- loader->exec->GS = loader->size->GS;
+ exec->GS = loader->size->GS;
/* XXX: UNDOCUMENTED! Hinting instructions of a composite glyph */
/* completely refer to the (already) hinted subglyphs. */
@@ -860,7 +860,7 @@
exec->is_composite = is_composite;
exec->pts = *zone;
- error = TT_Run_Context( loader->exec );
+ error = TT_Run_Context( exec );
if ( error && exec->pedantic_hinting )
return error;
--
2.41.0
