On Mittwoch, 25. März 2026 18:14:16 Mitteleuropäische Normalzeit Chu, Al wrote: > Hi, > > Going into the future I can set an annotated tag.
Thanks!
> > PS: As FREEIPMI_PACKAGE_VERSION_* in configure.ac is unused for years,
> > I could send a cleanup patch. Should I send it here or is there another to
> > contribute?
>
> That is substituted into freeipmi header files, so it should stay.
Yep, it is substituted into header files, but those seem to be unused
in C code:
git/freeipmi> grep FREEIPMI_PACKAGE_VERSION . -r
./libfreeipmi/include/freeipmi/freeipmi.h.in:#define FREEIPMI_PACKAGE_VERSION
@PACKAGE_VERSION@
./libfreeipmi/include/freeipmi/freeipmi.h.in:#define
FREEIPMI_PACKAGE_VERSION_MAJOR @FREEIPMI_PACKAGE_VERSION_MAJOR@
./libfreeipmi/include/freeipmi/freeipmi.h.in:#define
FREEIPMI_PACKAGE_VERSION_MINOR @FREEIPMI_PACKAGE_VERSION_MINOR@
./libfreeipmi/include/freeipmi/freeipmi.h.in:#define
FREEIPMI_PACKAGE_VERSION_PATCH @FREEIPMI_PACKAGE_VERSION_PATCH@
./configure.ac:FREEIPMI_PACKAGE_VERSION_MAJOR=1
./configure.ac:FREEIPMI_PACKAGE_VERSION_MINOR=6
./configure.ac:FREEIPMI_PACKAGE_VERSION_PATCH=17
./configure.ac:AC_SUBST(FREEIPMI_PACKAGE_VERSION_MAJOR)
./configure.ac:AC_SUBST(FREEIPMI_PACKAGE_VERSION_MINOR)
./configure.ac:AC_SUBST(FREEIPMI_PACKAGE_VERSION_PATCH)
No *.c file is making use of FREEIPMI_PACKAGE_VERSION_*
On the other hand side it may just not be worth it.
I was confused by the 1.7.0 version defined there, but if
this is intended and freeipmi-1-6-0-stable is the branch to be used for
1.6.X version definitions, it's not wrong and may be used in the future...
Thanks for your quick response,
Thomas
signature.asc
Description: This is a digitally signed message part.
