On Mon, Sep 15, 2025 at 02:26:12PM +0800, Xiangxu Yin wrote: > > On 9/12/2025 8:10 PM, Dmitry Baryshkov wrote: > > On Fri, Sep 12, 2025 at 07:54:31PM +0800, Xiangxu Yin wrote: > >> On 9/12/2025 7:46 PM, Dmitry Baryshkov wrote: > >>> On Fri, Sep 12, 2025 at 07:39:16PM +0800, Xiangxu Yin wrote: > >>>> Add DisplayPort controller for Qualcomm SM6150 SoC. > >>>> SM6150 shares the same configuration as SM8350, its hardware capabilities > >>>> differ about HBR3. Explicitly listing it ensures clarity and avoids > >>>> potential issues if SM8350 support evolves in the future. > >>> The controller is exactly the same as the one present on SM8150. HBR3 is > >>> a property of the PHY. > >> > >> Ok, will update commit msg. > > Please red my response again. What does it says to you wrt bindings? > > > > Yes, SM6150 uses the same DisplayPort controller IP as SM8150. I wasn’t > previously familiar with how fallback compatibility is defined in the > bindings. Since SM6150 will be declared as a fallback to sm8350-dp, is it > fine to drop the driver patch ([2/2])?
Yes > > Here’s the updated commit message for [1/2], does it match your expectation? > 'SM6150 uses the same controller IP as SM8150. Declare SM6150 as a fallback > compatible to sm8350-dp for consistency with existing bindings and to ensure > correct matching and future clarity.' I'd prefer if we have "qcom,sm6150-dp", "qcom-sm8150-dp", "qcom-sm8350-dp". -- With best wishes Dmitry
