On 8/28/2025 7:05 PM, Dmitry Baryshkov wrote: > On 28/08/2025 07:51, Xiangxu Yin wrote: >> >> On 8/20/2025 6:18 PM, Dmitry Baryshkov wrote: >>> On Wed, Aug 20, 2025 at 05:34:43PM +0800, Xiangxu Yin wrote: >>>> Add DisplayPort controller for Qualcomm SM6150 SoC. >>>> While SM6150 currently shares the same configuration as SC7180, >>>> its hardware capabilities differ. Explicitly listing it ensures clarity >>>> and avoids potential issues if SC7180 support evolves in the future. >>> I assume, it has no MST support. Am I right? >> >> >> From sm6150 ipcat, I found MST-related registers and pixel1 clk definition. > > Then please describe MST as the main difference between SM6150 and SC7180 > (which doesn't have MST). > > Also this needs to be rebased on top of the MST bindings. I've picked up the > latest posted revision, but basing on the on-list discussion I might need to > drop it and post another iteration. >
Would you prefer I keep the current patch and update the description of the MST capability difference with SC7180 in the commit message, or rebase on your series and update the dt-binding accordingly? https://lore.kernel.org/all/[email protected] Since MST support is not yet mainlined in the DP driver, even if I rebase now, the final implementation may require redefining msm_dp_desc for SM6150 in both the dt-binding and the driver once MST lands. >> >> According to the hardware spec, MST is supported, but due to limitations in >> clock and pipe resources, >> >> the maximum concurrency capability is restricted to 1920x1200@60 + >> 1280x720@60. >> >> >>>> Signed-off-by: Xiangxu Yin <[email protected]> >>>> --- >>>> Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>>> b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>>> index >>>> 9923b065323bbab99de5079b674a0317f3074373..996d0132e084d401db85014a1a4e445d00d62ed8 >>>> 100644 >>>> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>>> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>>> @@ -27,6 +27,7 @@ properties: >>>> - qcom,sc8280xp-dp >>>> - qcom,sc8280xp-edp >>>> - qcom,sdm845-dp >>>> + - qcom,sm6150-dp >>>> - qcom,sm8350-dp >>>> - qcom,sm8650-dp >>>> - items: >>>> >>>> -- >>>> 2.34.1 >>>> > >
