On 8/20/2025 7:47 PM, Dmitry Baryshkov wrote:
> On Wed, Aug 20, 2025 at 05:34:47PM +0800, Xiangxu Yin wrote:
>> Extend qmp_usbc_offsets and qmp_phy_cfg with DP-specific fields,
>> including register offsets, init tables, and callback hooks. Also
>> update qmp_usbc struct to track DP-related resources and state.
>> This enables support for USB/DP switchable Type-C PHYs that operate
>> in either mode.
>>
>> Signed-off-by: Xiangxu Yin <[email protected]>
>> ---
>> drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 73
>> ++++++++++++++++++++++++--------
>> 1 file changed, 55 insertions(+), 18 deletions(-)
>>
>>
>> + struct regmap *tcsr_map;
>> + u32 vls_clamp_reg;
>> + u32 dp_phy_mode_reg;
>> +
>> struct mutex phy_mutex;
>>
>> + struct phy *usb_phy;
> Should be a part of the previous patch.
Ok, will move usb_phy rename to patch 'Rename USB-specific ops',
then shall I need drop the |Reviewed-by| tag in that patch since it will change?
>> enum phy_mode mode;
>> unsigned int usb_init_count;
>>
>> - struct phy *phy;
> Similarly.
Ack.
>> -
>> - struct clk_fixed_rate pipe_clk_fixed;
>> + struct phy *dp_phy;
>> + unsigned int dp_aux_cfg;
>> + struct phy_configure_opts_dp dp_opts;
>> + unsigned int dp_init_count;
>>
>> struct typec_switch_dev *sw;
>> enum typec_orientation orientation;
>> @@ -874,11 +911,11 @@ static int qmp_usbc_typec_switch_set(struct
>> typec_switch_dev *sw,
>> qmp->orientation = orientation;
>>
>> if (qmp->usb_init_count) {
>> - qmp_usbc_usb_power_off(qmp->phy);
>> - qmp_usbc_com_exit(qmp->phy);
>> + qmp_usbc_usb_power_off(qmp->usb_phy);
>> + qmp_usbc_com_exit(qmp->usb_phy);
>>
>> - qmp_usbc_com_init(qmp->phy);
>> - qmp_usbc_usb_power_on(qmp->phy);
>> + qmp_usbc_com_init(qmp->usb_phy);
>> + qmp_usbc_usb_power_on(qmp->usb_phy);
> and these.
Ack.
>> }
>>
>> mutex_unlock(&qmp->phy_mutex);
>> @@ -1106,14 +1143,14 @@ static int qmp_usbc_probe(struct platform_device
>> *pdev)
>> if (ret)
>> goto err_node_put;
>>
>> - qmp->phy = devm_phy_create(dev, np, &qmp_usbc_usb_phy_ops);
>> - if (IS_ERR(qmp->phy)) {
>> - ret = PTR_ERR(qmp->phy);
>> + qmp->usb_phy = devm_phy_create(dev, np, &qmp_usbc_usb_phy_ops);
>> + if (IS_ERR(qmp->usb_phy)) {
>> + ret = PTR_ERR(qmp->usb_phy);
>> dev_err(dev, "failed to create PHY: %d\n", ret);
>> goto err_node_put;
>> }
>>
>> - phy_set_drvdata(qmp->phy, qmp);
>> + phy_set_drvdata(qmp->usb_phy, qmp);
>>
>> of_node_put(np);
>>
>>
>> --
>> 2.34.1
>>
