On Sat, Apr 19, 2025 at 08:03:35PM +0530, Akhil P Oommen wrote: > On 1/9/2025 2:10 AM, Akhil P Oommen wrote: > > Add a new schema which extends opp-v2 to support a new vendor specific > > property required for Adreno GPUs found in Qualcomm's SoCs. The new > > property called "qcom,opp-acd-level" carries a u32 value recommended > > for each opp needs to be shared to GMU during runtime. > > > > Also, update MAINTAINERS file include the new opp-v2-qcom-adreno.yaml. > > > > Cc: Rob Clark <[email protected]> > > Signed-off-by: Akhil P Oommen <[email protected]> > > --- > > .../bindings/opp/opp-v2-qcom-adreno.yaml | 97 > > ++++++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 98 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml > > b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml > > new file mode 100644 > > index 000000000000..de1f7c6c4f0e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml > > @@ -0,0 +1,97 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/opp/opp-v2-qcom-adreno.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm Adreno compatible OPP supply > > + > > +description: > > + Adreno GPUs present in Qualcomm's Snapdragon chipsets uses an OPP > > specific > > + ACD related information tailored for the specific chipset. This binding > > + provides the information needed to describe such a hardware value. > > + > > +maintainers: > > + - Rob Clark <[email protected]> > > + > > +allOf: > > + - $ref: opp-v2-base.yaml# > > + > > +properties: > > + compatible: > > + items: > > + - const: operating-points-v2-adreno > > + - const: operating-points-v2 > > https://lore.kernel.org/all/[email protected]/ > > Krzysztof, sorry for the late response. I was checking further about the > above bot error. AFAIU, we should not include "const: > operating-points-v2" here, otherwise all opp tables compatible with > "operating-points-v2" get matched with opp-v2-qcom-adreno.yaml during > validation. So I am sending the v5 revision with the below fix:
This is not quite correct. The table is compatible with op-v2. Instead you should add 'select:' clause which will limit the cases where this schema gets selected. > > +++ b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml > @@ -19,9 +19,8 @@ allOf: > > properties: > compatible: > - items: > - - const: operating-points-v2-adreno > - - const: operating-points-v2 > + contains: > + const: operating-points-v2-adreno > > -Akhil. > -- With best wishes Dmitry
