On 14.06.2023 16:22, Bjorn Andersson wrote:
> From: Bjorn Andersson <[email protected]>
> 
> Add memory reservation for the zap-shader and enable the Adreno SMMU,
> GPU clock controller, GMU and the GPU nodes for the SC8280XP CRD and the
> Lenovo ThinkPad X13s.
> 
> Tested-by: Steev Klimaszewski <[email protected]>
> Signed-off-by: Bjorn Andersson <[email protected]>
> Tested-by: Johan Hovold <[email protected]>
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

one question below
>  arch/arm64/boot/dts/qcom/sc8280xp-crd.dts          | 14 ++++++++++++++
>  .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts     | 14 ++++++++++++++
>  2 files changed, 28 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts 
> b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> index cd7e0097d8bc..b566e403d1db 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> @@ -210,6 +210,11 @@ vreg_wwan: regulator-wwan {
>       };
>  
>       reserved-memory {
> +             gpu_mem: gpu-mem@8bf00000 {
Is it ever going to differ on other platforms, including the automotive ones?

Konrad
> +                     reg = <0 0x8bf00000 0 0x2000>;
> +                     no-map;
> +             };
> +
>               linux,cma {
>                       compatible = "shared-dma-pool";
>                       size = <0x0 0x8000000>;
> @@ -390,6 +395,15 @@ &dispcc0 {
>       status = "okay";
>  };
>  
> +&gpu {
> +     status = "okay";
> +
> +     zap-shader {
> +             memory-region = <&gpu_mem>;
> +             firmware-name = "qcom/sc8280xp/qcdxkmsuc8280.mbn";
> +     };
> +};
> +
>  &mdss0 {
>       status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts 
> b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> index 5ae057ad6438..7cc3028440b6 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> @@ -264,6 +264,11 @@ vreg_wwan: regulator-wwan {
>       };
>  
>       reserved-memory {
> +             gpu_mem: gpu-mem@8bf00000 {
> +                     reg = <0 0x8bf00000 0 0x2000>;
> +                     no-map;
> +             };
> +
>               linux,cma {
>                       compatible = "shared-dma-pool";
>                       size = <0x0 0x8000000>;
> @@ -518,6 +523,15 @@ &dispcc0 {
>       status = "okay";
>  };
>  
> +&gpu {
> +     status = "okay";
> +
> +     zap-shader {
> +             memory-region = <&gpu_mem>;
> +             firmware-name = "qcom/sc8280xp/LENOVO/21BX/qcdxkmsuc8280.mbn";
> +     };
> +};
> +
>  &mdss0 {
>       status = "okay";
>  };

Reply via email to