Re: [Freedreno] [PATCH v5 2/3] drm/msm/dp: replace variable err with len at dp_aux_link_power_up()

[Dmitry Baryshkov]

On 12/09/2022 19:23, Kuogee Hsieh wrote:

drm_dp_dpcd_readb() will return 1 to indicate one byte had been read
successfully. This patch replace variable "err" with "len" have more
correct meaning.

changes in v5:
-- split into 3 patches

Signed-off-by: Kuogee Hsieh <quic_khs...@quicinc.com>

Reviewed-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org>

---
  drivers/gpu/drm/msm/dp/dp_link.c | 14 +++++++-------
  1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/msm/dp/dp_link.c b/drivers/gpu/drm/msm/dp/dp_link.c
index 36f0af0..9d5381d 100644
--- a/drivers/gpu/drm/msm/dp/dp_link.c
+++ b/drivers/gpu/drm/msm/dp/dp_link.c
@@ -49,21 +49,21 @@ static int dp_aux_link_power_up(struct drm_dp_aux *aux,
                                        struct dp_link_info *link)
  {
        u8 value;
-       int err;
+       ssize_t len;

if (link->revision < 0x11)

                return 0;

- err = drm_dp_dpcd_readb(aux, DP_SET_POWER, &value);

-       if (err < 0)
-               return err;
+       len = drm_dp_dpcd_readb(aux, DP_SET_POWER, &value);
+       if (len < 0)
+               return len;

value &= ~DP_SET_POWER_MASK;

        value |= DP_SET_POWER_D0;

- err = drm_dp_dpcd_writeb(aux, DP_SET_POWER, value);

-       if (err < 0)
-               return err;
+       len = drm_dp_dpcd_writeb(aux, DP_SET_POWER, value);
+       if (len < 0)
+               return len;

usleep_range(1000, 2000);

--
With best wishes
Dmitry