Now that we don't have the mmap_sem lock inversion, we don't need to
jump through this particular hoop anymore.

Signed-off-by: Kristian H. Kristensen <[email protected]>
---
 drivers/gpu/drm/msm/msm_gpu.c | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c
index 10babd18e286..9d51784c6664 100644
--- a/drivers/gpu/drm/msm/msm_gpu.c
+++ b/drivers/gpu/drm/msm/msm_gpu.c
@@ -446,21 +446,8 @@ static void recover_worker(struct work_struct *work)
                task = get_pid_task(submit->pid, PIDTYPE_PID);
                if (task) {
                        comm = kstrdup(task->comm, GFP_KERNEL);
-
-                       /*
-                        * So slightly annoying, in other paths like
-                        * mmap'ing gem buffers, mmap_sem is acquired
-                        * before struct_mutex, which means we can't
-                        * hold struct_mutex across the call to
-                        * get_cmdline().  But submits are retired
-                        * from the same in-order workqueue, so we can
-                        * safely drop the lock here without worrying
-                        * about the submit going away.
-                        */
-                       mutex_unlock(&dev->struct_mutex);
                        cmd = kstrdup_quotable_cmdline(task, GFP_KERNEL);
                        put_task_struct(task);
-                       mutex_lock(&dev->struct_mutex);
                }
 
                if (comm && cmd) {
-- 
2.21.0.225.g810b269d1ac-goog

_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno

Reply via email to