Hi,

On Mon, Jan 25, 2016 at 5:38 AM, Jerome E. Shidel Jr. <[email protected]> wrote:
>
> I was thinking of pulling the “autoexec & config loaded", "Welcome to FreeDOS”
> and "type help” messages out of the AUTOEXEC.BAT file and placing them in a
> %DOSDIR%\BIN\WELCOME.BAT file with the language translation files in
> %DOSDIR%\NLS\WELCOME.%LANG%. Also, installing them via a WELCOME.ZIP
> package. At present, FDI embeds the required stuff into a newly created
> AUTOEXEC.BAT.

Not the worst idea (although it's not very much crucial info).

> 1) This would make the AUTOEXEC.BAT file a little cleaner with just a:
>
> if exist %DOSDIR%\BIN\WELCOME.BAT CALL %DOSDIR%\BIN\WELCOME.BAT

Okay, but just for the record, there are some (very minor) problems with this:

Having the file name and path twice is redundant, thus harder to
change, more error-prone, etc.

A better solution would be something like "for %%a in
(%DOSDIR%\BIN\welcome.bat) do if exist %%a call %%a".

Of course, just "call %DOSDIR%\BIN\welcome.bat" isn't horrible either,
just a mild error message if not found, which is benign, so you can
just ignore it. It's not worth overthinking minor things like this,
they don't need error checking.

> 2) Easily remove the messages with a "fdinst remove welcome” command.

It's probably not even obtrusive enough to even bother "removing".

> Thoughts?

That's all.  :-)

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Freedos-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freedos-devel

Reply via email to