Hi FreeCOM experts, could somebody modify the context memory display to make it a bit more correct? Problem is that it has many translations which will need adjustment, but even that should be possible without speaking the languages :-) Thanks in advance!
The command in question is called MEMORY... Problem 1: FreeCOM 0.84 shows the "last dir cache" info in a line which claims to show "dir stack" info. On the other hand, the "dir stack" info is not shown at all in 0.84 (?). This problem does not happen in 0.82 :-) Problem 2: FreeCOM claims that aliases, history and dir stack have a "limit" / "maximum size", yet this limit is only enforced for aliases. In general, all context areas have unlimited size until the context memory is full, and when that happens, you get a one-time warning (*) and the history goes into "first in first out" mode which starts forgetting the oldest entries to make context RAM free as needed whenever new data of any kind comes in in any area of the context memory. So the "limit" should not be shown for history / dir stack, as it is not used anyway. Problem 3: The * warning "out of context memory" gives the impression that there would be a memory leak and/or you should reserve more space for history / dirstack / ... This is not the case - you simply used freecom long enough to collect so much command history data that the oldest entries have to be discarded. If you ask me, there should not be any message about that at all. Problem 4: The swapinfo always shows 0 used in 0 items, maybe it should be disabled for xms-swap freecom / maybe it is only useful for the disk-swap freecom versions? Problem 5: MEMORY always says that you have 0 items defined in aliases, but it should show the actual number of aliases. In addition, the last dir cache is always 0 or 1 elements, so that is not worth mentioning in the MEMORY output anyway. As you can see, ALL of those errors are purely cosmetical, yet www.freedos.org/bugzilla/cgi-bin/show_bug.cgi?id=1734 was marked as a MAJOR memory leak bug. So the bogus error message and the misleading MEMORY display do need fixing, not because they are symptom of a major error but because they cause major confusion :-). It would be great if a FreeCOM expert could have a look at the cmd/memory.c file and at the translated message strings and at include/context.h to clean up the MEMORY output. In addition, the "context memory full" message (this is called TEXT_ERROR_CONTEXT_OUT_OF_MEMORY) should be disabled/removed. You can also remove TEXT_ERROR_CONTEXT_LENGTH and shorten the debugging message TEXT_ERROR_CONTEXT_ADD_STATUS. They are handled by lib/err6[125].c lib/err_fcts.src but mainly by lib/chgctxt.c and lib/ctxt_mk.c :-) The latter does, by the way, imply that "max" is only related to "maximum per element size", not worth mentioning in MEMORY output while the former invokes error_context_out_of_memory at 2 places where one of both is probably wrong. Yet I cannot tell which, and I cannot tell why the message is only shown once. Odd! Thanks for you help :-) Eric ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Freedos-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freedos-devel
