At 03:36 PM 2/16/2005 +0100, Eric Auer wrote:
Hi Tom, Michael, not giving up on that one yet...
Look, I don't know about those extended video UMB options, wouldn't use them, couldn't test them properly, and have little of an opinion one way or the other about them. Just like with a lot of other stuff in FreeDOS.
If Tom says he thinks the option is dangerous, but not unacceptable, then it can go in. Write it and test it for basic errors, give to me or Tom to stick in an EMM386 official release. End of story. Don't expect me to download a few code fragments you dreamed up and turn them into a finished tested product.
Next issue: Filling gaps in EMS 4 specs. Please do check my diff and give us access to a binary with it... Then I can check the pros (e.g. whether some MEM style tools here get happier) and the cons (e.g. how much the footprint grows - if most of the handler is in high memory, then it really does not hurt to have 4k higher XMS overhead in handle 0).
Well, let's see here. In the first screen, I see you correcting typos on commented-out messages. Then a comment word typo fix, and changes to working but slightly inconsistently declared forms of labels. Oh, and a tab change or two. Why are you wasting my time with this crap? Then, finally, real code which basically looks right with only a couple of suspicious parts. And what is this: You have a FIXME in your added code?! Good grief, if you can't be bothered, why should I?
Rather than get all excited and froth at the mouth, I'll compromise on this issue. I'll add in the code you supplied which looks correct, has minimal potential impact elsewhere, and has the greatest chance of actually making a difference someday, somewhere, some how, some way. Besides EMS, that includes the VCPI debug register support you so desperately want, dating back to the initial VCPI release.
For the record, I spent a good deal of last night doing nothing but searching out, downloading, and testing old DOS applications on the net which use EMS. Including a couple of really goofy ones. None of them used EMS calls beyond the currently supported API. However, Manifest may stress things harder, so I'll test that too.
Then, I'm done.
------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Freedos-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freedos-devel
