Hi folks,

just stubled across some lines in TilePanel constructor, that look
a bit strange to me:

150> final UnitType expert = spec.getExpertForProducing(gt);
151> if (expert != null) {
152>     expertPotential = (int)expert.applyModifiers(amount,
153>         getGame().getTurn(), gt.getId());
154> }

This applies a modifiers which have exactly the same as the goods type.
It that really a good idea ? Wouldn't it be better to use scopes here ?

OTOH, this is just in the gui - shouldn't there be a counterpart in
the production calculation (ProductionCache ?) ?


--mtx

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Freecol-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Reply via email to