On Tue, 24 Jan 2017 18:10:19 +0100
"Enrico Weigelt, metux IT consult" <[email protected]> wrote:
> On 24.01.2017 12:12, Michael T. Pope wrote:
> 
> > Always the performance... for the nth time, show me that it is a problem!  
> 
> Well, eg. up to several seconds delay on map move, etc actually is a
> problem - at least for me ...

Apparently.  Now do you recall what wintertime and I said a while back
about optimization?  The GUI, specifically MapViewer is known to be slow.
Apparently *very* slow in your case, I suspect there may be something
particular to your system going on there.  May I again suggest that you
look into why MapViewer is slow?  I hope you can understand some of my
exasperation in that you have submitted 180 odd optimization patches none
of which touch the one area that has been reproducably shown to be bad.
 
>> Java8 is not negotiable.
> Does that mean, using j8 stuff whereever possible, just for its own
> sake ?

No.  Why do you say that?

> > Java7 is no longer getting security updates.  
> 
> LTS distros still do it. (OTOH, for plain desktop applications, the
> pressure isn't that high anyways.)

Ahem.  I am quite able to be a hard core Linux purist too, but our users
are not.  Or were you volunteering to maintain Java7 for Windows, Macs and
non-LTE linux distros?

That said, you should also know that I do security professionally and have
spent far too much time cleaning after people who insist on hanging on to
their known vulnerable software.  The FreeCol project generally was
burned a while back due to the website being exploited, which wasted
quite enough of my and other volunteer's time.  I have no wish to waste
more.

> > It *is* more "explicit" in that you are correct that the types are more 
> > obvious,
> > but I do not consider that an advantage over being succinct.  
> 
> For me it *is* important. Everytime I see such an expression, I'll have
> to look up which the actual types, to understand what's really going on
> here, just because some people wanna save a few keystrokes ...

Keystrokes are a simple proxy for expressiveness, not the aim in
themselves.  I want to use high level constructs.  Java may indeed not be
particularly functional, but that is no reason not to use some
functional-like constructs.

As to your preference for seeing all the types, I doubt we will agree on
this.

> And I dont wanna waste so much memory for all the temporary objects,
> (my notebook only has 8GB RAM,

Likewise.  My main development machine is almost 11 years old.  If you
think memory is an issue, enable the garbage collection logging
(IIRC its something like -verbose:gc) and see if it is being triggered a
lot.  Note we tend to run FreeCol with -Xmx512M.

> > So *what* exactly is "magnitudes smaller"?    
> 
> Sorry, a bit fallen over --- AI is magnitudes slower here. In larger
> games (when the AIs have lots of colonies and units), up to a minute
> per turn. That's the point, where it really doesn't make fun anymore.

Well I have to admit I do not see many games where AIs have lots of
colonies.  Usually some human wipes them out.  So what do you mean by
"lots"?  Do you have a savegame that can be tested?  If so please attach.

However, the simplest explanation is, again, the GUI.  My tests are
headless.

That said, the next most likely explanation for your patches improving
matters is the Map handling (because that *does* impact MapViewer).  What
happens if you apply just that patch?

> > However I expect you will find that most of
> > the time is I/O, sending the XML for the Game to the client.  
> 
> Yeah, already suspected that. Maybe I'll just replace the XML bloat
> by something thinner and faster ... (or maybe just a faster xml
> parser)

That is underway, but going slowly.  org.w3c.dom.* is very common,
and proving painful to remove.  We try to work incrementally because the
skilled users that report bugs against trunk are of immense value.

Cheers,
Mike Pope

Attachment: pgpRyvIXroJQj.pgp
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Freecol-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Reply via email to