On Mon, 27 Jul 2015 16:57:28 +0200 [email protected] wrote: >>[splash.jpg] > I think the reason its there is that its needed early on in the startup > process of the game to show activity and to ensure it is always found. > So its placed near the FreeCol.jar, with a hardcoded position in > FreeCol.java, which can only be overwritten through the --splash option, > Then its directly loaded in displaySplashScreen, which gets called even > before the ResourceManager is initialized. > As we support movable a data folder I would be wary of moving it there. > It might be possible to shove it into the jar and add some magic to > read it out of that, but is it really worth doing?
Its pretty minor. If we are doing a file-tidy-up I think its a good idea, but low priority. > I found another file that seems unused, data/freecol.png. > Visually it is extremely similar to data/base/frame_icon.png, but has > a different filesize. I grepped for the name and its only showing > src/net/sf/freecol/tools/DesktopEntry.java. I guess this is an unused > tool and therefore an unused file, as we have a premade .desktop file > in packaging/common and it references some .xpm file there. IIRC .png is more scalable than .xpm, so the intent may have been to use it for the .desktop file. That work never quite got finished (BR#2515). I would leave it alone for now, or perhaps put it in a subdirectory with the .java so we know they are associated. > You expect a longer delay from BR#2876 (or the SF outage)? The BR#2876 crash is fixed, so I do not consider it a blocker. It would be nice to fix the associated InformationPanel issue. I can not really comment on delay at SF, but will try another dist upload shortly. Cheers, Mike Pope
pgpIP8J3au__1.pgp
Description: OpenPGP digital signature
------------------------------------------------------------------------------
_______________________________________________ Freecol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freecol-developers
