On 10/05/2013 05:59 AM, Michael T. Pope wrote:
> On Fri, 04 Oct 2013 15:56:28 +0200
> Michael Vehrs <[email protected]> wrote:
>> I understand now. Try the attached patch for size.
> Ta.  That broke the blockage I was experiencing.  I kicked it a bit more,
> and now with git.561ef0c we have tool tips for complex string option
> values (native land builds, starting positions), the language option is
> fixed, and missing i18n for message grouping has been added.
>
> In the interest of robustness I added Messages.getBestNameAndDescription,
> which tries to find the .name form first, but degrades to the non-.name
> form and then the base id, and also returns the best description if
> the .name was present.  Previously we were using a default tool tip equal
> to the text in the box if no good description was found.  I think this is
> unnecessary and so if gBNAD fails to find a non-degenerate description I
> do not enable a tooltip, however this is easily reverted if anyone wishes
> to object.
>
> Known remaining problems with options:
>
>    - The load/save custom file dialog pops up behind the options
>      dialog.  Getting to that one soon.
>
>    - The borken REF editing mentions upthread.
>
>    - On my system if you view (not edit) the difficulty options the greying
>      out makes the text options (which are not on a white background)
>      invisible.  Is this the case for others?

Difficult to read yes, invisible no. We should probably tweak our colour 
scheme, now that we are using a greyish background. 3f3f3f as disabled 
colour works for me.

>
>> It might be possible to ignore the case localize == false entirely. I'm not 
>> sure.
> I suspect there are corner cases with language options, and/or early game
> messaging when the system locale default language is in effect before
> loading the saved-game language message bundle.  However I am also unsure.
>
> Cheers,
> Mike Pope

Unfortunately, swing does not follow the platform's UI conventions with 
regard to button placement, which means that the new dialogs place their 
buttons incorrectly. MigLayout does the right thing, but only if the 
buttons are tagged appropriately.


Regards

Michael



------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
_______________________________________________
Freecol-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Reply via email to