Hi Michael, On Wed, Dec 12, 2012 at 11:25 AM, Michael T. Pope <[email protected]> wrote: > On Sun, 9 Dec 2012 11:40:48 AM Paolo Bizzarri wrote: >> please find a patch that makes FreeColClient and GUI two interfaces, >> in order to make it easier to test client controllers in unit tests. >>... >> Please let me know if this patch makes sense. > > I can see what you are trying to do, but the patch did not apply. > I suspect a missing -a switch. >
For sure. I will send a proper patch this evening. > BTW, I have been play testing a fair bit, which inevitably ends up with a bug > hunt in ColonyPanel:-S, and I noticed that we have a bunch of panels that have > both a FreeColClient and a GUI in their constructor arguments. This seems > redundant since FreeColClient.getGUI() exists. > I think this is something we want to avoid - expecially with the new test code. Otherwise, you will find yourself having to mock a freeColClient.getGUI.... Regards. PaoloB > Cheers, > Mike Pope > > ------------------------------------------------------------------------------ > LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial > Remotely access PCs and mobile devices and provide instant support > Improve your efficiency, and focus on delivering more value-add services > Discover what IT Professionals Know. Rescue delivers > http://p.sf.net/sfu/logmein_12329d2d > _______________________________________________ > Freecol-developers mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/freecol-developers > ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ Freecol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freecol-developers
