I think it would be a good idea to split the MapGenerator into several components. I think the map import code liberally sprinkled here and there should be combined into a MapLoader able to load various layers of a map from another game. In the future, someone might write other MapLoaders able to load layers of a map from an image, or from an original Colonization file (or possibly from a savegame of the remake), or from some future format. And I think the generator itself should be split into a number of different MapLayerGenerators, one or several for each layer of the map. At some point in the future, we might have several implementations of MapLayerGenerators for the same layer, and make them selectable.
Map regions present a problem, however. Should we add another map layer for regions, and a corresponding region layer generator? Or should the generating of regions be handled by the Map itself? The terrain generator contains code for generating regions in case the imported map lacks them. Is this compatibility code? Regards Michael ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ Freecol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freecol-developers
