On Wed, 17 Oct 2012 06:43:42 AM Michael Vehrs wrote: > One possible simplification of the OptionGroup class would be to remove > its hash map. We rarely retrieve a value from an option group directly, > and could easily stop doing that. Instead, we usually retrieve options > from their top-level containers, namely the specification and the client > options. The specification already contains an option map, and such a > map could be easily added to the client options, too. Better yet, both > the specification and the client options could be derived from a common > "option container" class.
Sounds worth doing. It would certainly be cleaner. Rolling back to the previous post... > I think it would be better to check whether the difficulty levels > contain further option groups, and to add the new options as a group, or > singly, depending on the result of this check. OK, the policy then is to try to follow the style of the loaded client options when adding fixup options. Cheers, Mike Pope
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________ Freecol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freecol-developers
