Hi HPS, Sorry, but I just have Intel SOC which only has XHCI integrated, I just tested with Intel's Gemini Lake SOC, and I can further test it with DELL OptiPlex later. I agree with your idea that preserves old behavior by default.
Thanks & Regards, Shichun Ma Software Engineer Dell | Cloud Client Computing office +86 10 82862579, Mobile +86 13241851528 [email protected] ________________________________________ From: Hans Petter Selasky <[email protected]> Sent: Friday, January 17, 2020 9:57 PM To: Ma, Horse; [email protected] Cc: [email protected] Subject: Re: USB keyboard/mouse wake up from S3 [EXTERNAL EMAIL] On 2020-01-17 10:41, Hans Petter Selasky wrote: > On 2020-01-17 04:23, [email protected] wrote: >> >> HPS, >> >> Here is my patch to enable USB wakeup under XHCI, I tested USB >> mouse/keyboard can wake up system from S3. >> > > Hi, > > Patches look OK, with some minor nits. > > Have you thought about adding EHCI/OHCI/UHCI to the wakeup matrix aswell? > > How many different computers and CPU architectures has this code been > tested with? > Also I want you to add a sysctl, hw.usb.no_wakeup, which if set, preserves the old behaviour. Thank you! --HPS _______________________________________________ [email protected] mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "[email protected]"
