On 12/26/19 7:54 PM, Mark Millard wrote:
> Context: devel/freebsd-gcc* (for example)
> using:
> 
>                 --with-as=${LOCALBASE}/bin/${BU_PREFIX}-as \
>                 --with-ld=${LOCALBASE}/bin/${BU_PREFIX}-ld
> 
> The likes of ${BU_PREFIX}-ld possibly also
> exists someplace else on the path in use.
> So I suggest that the BUILD_DEPENDS and
> RUN_DEPENDS cause the full path to be
> checked so that the full path will be
> created if they do not exist already.
> So, using devel/freebsd-gcc9 as an example,
> . . .
> 
> 
> # svnlite diff /usr/ports/devel/freebsd-gcc9/
> Index: /usr/ports/devel/freebsd-gcc9/Makefile
> ===================================================================
> --- /usr/ports/devel/freebsd-gcc9/Makefile    (revision 520539)
> +++ /usr/ports/devel/freebsd-gcc9/Makefile    (working copy)
> @@ -16,8 +16,8 @@
>  LIB_DEPENDS= libgmp.so:math/gmp \
>               libmpfr.so:math/mpfr \
>               libmpc.so:math/mpc
> -BUILD_DEPENDS=       ${BU_PREFIX}-as:devel/binutils@${TARGETARCH}
> -RUN_DEPENDS= ${BU_PREFIX}-as:devel/binutils@${TARGETARCH}
> +BUILD_DEPENDS=  ${LOCALBASE}/bin/${BU_PREFIX}-as:devel/binutils@${TARGETARCH}
> +RUN_DEPENDS=    ${LOCALBASE}/bin/${BU_PREFIX}-as:devel/binutils@${TARGETARCH}
>  
>  FLAVORS=     aarch64 amd64 i386 mips mips64 powerpc powerpc64 riscv64 sparc64
>  TARGETARCH=  ${FLAVOR}
> 
> This avoids later not finding the file via
> the full path in such contexts.

I don't see why this would ever be the case that we'd have, say,
x86_64-unknown-freebsd13.0-ld anywhere but in LOCALBASE from the
amd64-binutils package.

base/binutils only installs /usr/bin/ld and /usr/${BUTARGET}/bin/ld.
It doesn't install a BUTARGET-ld binary anywhere.  I might end up
axeing /usr/BUTARGET/bin from the base/binutils package.  I've
trimmed most of the similar type files from base/gcc6 recently.

-- 
John Baldwin
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "[email protected]"

Reply via email to