On 3/21/2012 10:50 AM, Martin McCormick wrote:
I've got some code which I wrote about 6 or 8 years ago that
apparently doesn't get along right now with FreeBSD9.0. In the
problem code, there is a loop that uses fgets to read a line
from a file. It runs properly until the 2708TH iteration and
then it dumps core with a segmentation fault.

char string0[256];
more lines of code . . .

while ( fgets(string0,sizeof(string0),fp_config)) {
code to be run for each line
}

        It runs fine until the 2,709TH iteration. Instead of
reading the next line, it jumps to the line that closes
fp_config even though it is far from read and exits with the
segmentation fault.

        The man page on fgets says that if errors occur while
running fgets, one must use perr to see whether the error
terminated activity or it was the end of the file. In this case,
it is definitely the error.

        Some observations:

The crash occurs on the 2,709TH input no matter how long I
declared string0 to be. string0 is over-written each new
iteration so nothing should be accumulating that uses up
resources.

        Maybe I am declaring string0 in the wrong data type.
Originally, it had been 1024 characters long but 2709 seems to
be the C equivalent to the apocalypse and I thought it was
supposed to be next December:-)

        This same code, by the way, also fails at about the same
number of iterations if one uses fgetc and  builds the line one
char at a time.


Have you tried allocating a large block of maybe 15-20k (using alloc, or calloc) instead of declaring it on the stack? You can print the length of the line (and iteration count) for each line processed and see what max line length is.

What you describe sounds more like a problem with the content of the file overflowing the space allocated and causing a stack fault than something wrong with fgets (especially if fgetc and concatenating the string causes the same problem).

Also, what happens if you remove your processing code and replace it with a print of the line length & the iteration count? Compilers have been know to generate buggy loop code sometimes, so that's also a possibility.


--
Brad Mettee
PC HotShots, Inc.
Westminster, MD
(410) 848-0588
-> Let us bring out the **Power** of your PCs. <-
-> Custom Business Software Solutions since 1991 <-
Visit us <http://www.pchotshots.com> for information about our company.
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-questions
To unsubscribe, send any mail to "[email protected]"

Reply via email to