https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204435
Kubilay Kocak <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |maintainer-feedback?(vladim | |[email protected]) Keywords| |feature, needs-qa, patch, | |patch-ready CC| |[email protected], | |[email protected], | |[email protected] | |m Summary|[NEW PORT] |[NEW PORT] |graphics/py-mayavi |graphics/py-mayavi: | |Application and library for | |3D visualization and | |plotting in Python --- Comment #2 from Kubilay Kocak <[email protected]> --- Thanks Vladimir! On initial review: * Using PyPI (CHEESESHOP) for distribution files is preferred unless desirable files are missing from the sdist (LICENSE, test suite, etc) * If a LICENSE file exists in WRKSRC, add LICENSE_FILE=${WRKSRC}/path/to/LICENSE * I'm not confident that the declared dependencies are all BUILD_DEPENDENCIES. See: https://github.com/enthought/mayavi/blob/master/mayavi/__init__.py#L10 * GH_PROJECT defaults to PORTNAME, this entry is not needed * Instead of a pre-configure check for the/a python vtk module, there should be a (slave) port for either vtk with the option enabled (vtkX-python) OR, a port for py-pyvtk (https://pypi.python.org/pypi/PyVTK) if this is the module that is used. A pre-configure check assists port users who can rebuild vtk w/ PYTHON, but not package users. * Group USE{S_*} lines with USES at the top, and USE_* sorted -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ [email protected] mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "[email protected]"
