On 2026-10-27 07:30, Mathieu Arnold wrote:
On Mon, Oct 26, 2026 at 09:24:07PM +0100, Daniel Engberg wrote:
On 2026-10-26 20:09, Steve Kargl wrote:
On 10/26/26 11:57, Daniel Engberg wrote:
On 2026-10-26 19:49, Steve Kargl wrote:
On 10/26/26 11:43, Daniel Engberg wrote:
Try again, https://cgit.freebsd.org/ports/commit/?
id=d0528bbc1318371bfb9f81b3c1a4e56eeaab6c60
(I have no dog in this fight except the long email thread cluttering
my inbox.)
d0528bbc seems to be missing
DEPRECATED= "Port has been broken for 5 months"
EXPIRATION_DATE=2026-11-30
Seems like there was a space added by accident in the url
https://cgit.freebsd.org/ports/commit/?
id=d0528bbc1318371bfb9f81b3c1a4e56eeaab6c60
It is still missing DEPRECATED and EXPIRATION_DATE.
Here's the patch you meant to commit instead of removing
the port
diff --git a/x11/budgie-desktop/Makefile b/x11/budgie-desktop/Makefile
index 539584dfdc2e..722e89b949fe 100644
--- a/x11/budgie-desktop/Makefile
+++ b/x11/budgie-desktop/Makefile
@@ -9,7 +9,8 @@ MAINTAINER= [email protected]
COMMENT= Modern and familiar desktop environment
WWW= https://github.com/BuddiesOfBudgie/budgie-desktop
-BROKEN= Fails to build, vapigen command fails
+DEPRECATED= Fails to build, vapigen command fails
+EXPIRATION_DATE = 2016-11-26
LICENSE= GPLv2 LGPL21
LICENSE_COMB= multi
HTH
No, it's not. The port is broken so your suggested patch is wrong. The rest
makes no sense given it hasn't been available for 5+ months (once again).
Daniel,
That is true. That patch should keep the BROKEN line. This is not a
problem. Anyone can see that and keep the line.
Your personal preferences on how ports go away are only that. They are
not policy.
The long-standing policy is that ports that do not build get marked
BROKEN. This has two effects. First, the build clusters stop trying to
build ports that cannot finish. Second, the mark shows that the port is
broken. People who care about the port can then look at it.
After a while, a port marked BROKEN gets a DEPRECATED reason and an
EXPIRATION_DATE. The date is usually a few months in the future. The
change also needs a PORTREVISION bump. All of this must be merged to the
quarterly branch.
This shows that the port will be removed in the future, and why. The
reason is in DEPRECATED. For ports that build, users see a notice when
they upgrade. The notice says the port is deprecated and will go away.
This is important. The ports tree is not a playground for committers. It
exists so that users can use software.
Your commit removed six ports. Only one of them had a BROKEN tag. You
should have added DEPRECATED and EXPIRATION_DATE to the broken port. You
should also have set those variables on all ports that depend on that
broken port. Then all of them would be marked for deletion.
In the future, please follow that procedure.
That effectively applies to a library/port with non related projects
(consumers) and/or arguably that builds or at least are available.
It's not documented in either Porters Handbook or in the new policies as
such and there are conflicting messages, logical and practical
shortcomings. Since there's a discrepancy which several have recognized
there's already a discussion taking place and hopefully document it in
the end.
x11/budgie-desktop (suite) breaks everything related to it, and directly
(build level) x11/budgie (meta port), deskutils/budgie-desktop-view.
sysutils/budgie-control-center , x11/budgie-screensaver,
x11/budgie-session, x11-wm/magpie are effectively broken due to
budgie-desktop etc.
I agree that x11-themes/budgie-backgrounds is technically decoupled and
theoretically not affected by the main port being broken but is part of
the suite itself so that could've been technically considered kept.
The ports tree isn't a playground, there have been requests and
discussions for years of sustainability.
Best regards,
Daniel
