Am 29.01.2017 um 20:22 schrieb John Marino: > Author: marino > Date: Sun Jan 29 19:22:47 2017 > New Revision: 432796 > URL: https://svnweb.freebsd.org/changeset/ports/432796 > > Log: > graphics/rawtherapee(-devel): Fix OSVERSION, use with OPSYS > > The OSVERSION for FreeBSD 10.3 is 1003000, not 1030000. The last commit > blocked FreeBSD 10.3 too. OSVERSION is also supposed to be used in > conjunction with OPSYS. > > Approved by: just-fix-it > > Modified: > head/graphics/rawtherapee-devel/Makefile > head/graphics/rawtherapee/Makefile > > Modified: head/graphics/rawtherapee-devel/Makefile > ============================================================================== > --- head/graphics/rawtherapee-devel/Makefile Sun Jan 29 19:19:06 2017 > (r432795) > +++ head/graphics/rawtherapee-devel/Makefile Sun Jan 29 19:22:47 2017 > (r432796) > @@ -76,7 +76,8 @@ OPTIMIZED_CFLAGS_CFLAGS= -O3 -funroll-lo > # ------------------------------------------------------------------- > # > > -.if ${OSVERSION} < 1030000 > +.if ${OPSYS} == FreeBSD > +.if ${OSVERSION} < 1003000 > IGNORE= is only for supported FreeBSD releases > .endif >
Good catch, John, and thanks for the fix-up. I have one nit to pick about the OPSYS - where is it documented that OPSYS is mandatory for OSVERSION? It's not in bsd.port.mk unless I dive deep into the implementation, and not in the porter's handbook. I'm a FreeBSD ports committer and will not proactively deal with keeping my stuff compatible with other systems, let alone test there. Bottom line: I regularly omit the OPSYS checks because I have zero clue about the related versions on other systems, nor do I care. _______________________________________________ [email protected] mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "[email protected]"
